Skip to content

Documentation update #942

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 21, 2018
Merged

Documentation update #942

merged 1 commit into from
Mar 21, 2018

Conversation

MWL88
Copy link
Contributor

@MWL88 MWL88 commented Mar 21, 2018

PR Summary

Fixes a typo and enhances the documentation for the parameters required for script rules

This PR addresses issue #941

PR Checklist

Note: Tick the boxes below that apply to this pull request by putting an x between the square brackets. Please mark anything not applicable to this PR NA.

  • PR has a meaningful title
    • Use the present tense and imperative mood when describing your changes
  • Summarized changes
  • User facing documentation needed
  • Change is not breaking
  • Make sure you've added a new test if existing tests do not effectively test the code changed
  • This PR is ready to merge and is not work in progress
    • If the PR is work in progress, please add the prefix WIP: to the beginning of the title and remove the prefix when the PR is ready

@MWL88
Fix typo
9f109ae 
Update script rule function parameters description
JamesWTruher
JamesWTruher approved these changes Mar 21, 2018
View reviewed changes
Copy link
Contributor

@JamesWTruher JamesWTruher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
thanks!

@JamesWTruher JamesWTruher merged commit d6dc001 into PowerShell:development Mar 21, 2018
@MWL88 MWL88 mentioned this pull request Mar 21, 2018
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JamesWTruher JamesWTruher JamesWTruher approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@MWL88 @JamesWTruher